Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] More precise inference for chained boolean expressions #15089

Merged
merged 3 commits into from
Dec 22, 2024
Merged

[red-knot] More precise inference for chained boolean expressions #15089

merged 3 commits into from
Dec 22, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #13632.

Test Plan

Markdown tests.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Dec 21, 2024
carljm
carljm reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments.

carljm
carljm approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@carljm carljm merged commit 3b27d5d into astral-sh:main Dec 22, 2024
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-chained-booleans branch December 22, 2024 19:02
@InSyncWithFoo InSyncWithFoo mentioned this pull request Dec 23, 2024
Merged
carljm added a commit that referenced this pull request Dec 23, 2024
@InSyncWithFoo @carljm
[red-knot] Treat classes as instances of their respective metaclasses…
f764f59 
… in boolean tests (#15105)

## Summary

Follow-up to #15089.

## Test Plan

Markdown tests.

---------

Co-authored-by: Carl Meyer <carl@astral.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[red-knot] more precise types from chained boolean expressions
3 participants
@InSyncWithFoo @carljm @MichaReiser