Stream Method is asynchronous but without Async suffix #899

AhmedAbuelnour · 2017-09-16T14:02:41Z

Stream Method is asynchronous but without Async suffix in its name, it should be StreamAsync

davidfowl · 2017-09-16T14:03:23Z

Which Stream method?

AhmedAbuelnour · 2017-09-16T14:07:22Z

HubConnection connection = hubConnectionBuilder.WithUrl(url).Build();

await connection.Stream<>("", "");
I think it should be
await connection.StreamAsync<>("", "");

davidfowl · 2017-09-16T14:10:36Z

It's not async though. It returns a ReadableChannel<T>. It could be made async but that would require a code change.

Do you want to submit a pull request?

- Before we were fire and forgetting the invocation that initiated the streaming, this changes that so that the caller now has to await to get the channel. #899

AhmedAbuelnour · 2017-09-17T11:48:44Z

Yes, it would make more sense to be async

* Turned Stream into StreamAsync - Before we were fire and forgetting the invocation that initiated the streaming, this changes that so that the caller now has to await to get the channel. #899

davidfowl added 1 - Ready type: Bug labels Sep 17, 2017

davidfowl self-assigned this Sep 17, 2017

davidfowl added this to the 1.0.0-alpha2 milestone Sep 17, 2017

davidfowl added a commit that referenced this issue Sep 17, 2017

Turned Stream into StreamAsync

8d5db17

- Before we were fire and forgetting the invocation that initiated the streaming, this changes that so that the caller now has to await to get the channel. #899

davidfowl added 2 - Working and removed 1 - Ready labels Sep 17, 2017

davidfowl mentioned this issue Sep 17, 2017

Turned Stream into StreamAsync #902

Merged

davidfowl added 3 - Done and removed 2 - Working labels Sep 18, 2017

davidfowl closed this as completed Sep 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stream Method is asynchronous but without Async suffix #899

Stream Method is asynchronous but without Async suffix #899

AhmedAbuelnour commented Sep 16, 2017

davidfowl commented Sep 16, 2017

AhmedAbuelnour commented Sep 16, 2017

davidfowl commented Sep 16, 2017 •

edited

Loading

AhmedAbuelnour commented Sep 17, 2017

Stream Method is asynchronous but without Async suffix #899

Stream Method is asynchronous but without Async suffix #899

Comments

AhmedAbuelnour commented Sep 16, 2017

davidfowl commented Sep 16, 2017

AhmedAbuelnour commented Sep 16, 2017

davidfowl commented Sep 16, 2017 • edited Loading

AhmedAbuelnour commented Sep 17, 2017

davidfowl commented Sep 16, 2017 •

edited

Loading