Tweak libuv shutdown sequence #1735

davidfowl · 2017-04-21T16:58:16Z

Increase timeouts for thread and listener shutdowns
Use PostAsync to observe ObjectDisposedExceptions in the shutdown sequence

- Increase timeouts for thread and listener shutdowns - Use PostAsync to observe ObjectDisposedExceptions in the shutdown sequence

halter73 · 2017-04-21T17:41:28Z

src/Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv/Internal/LibuvThread.cs

@@ -103,15 +102,15 @@ public Task StartAsync()
            {
                var stepTimeout = TimeSpan.FromTicks(timeout.Ticks / 3);

-                Post(t => t.AllowStop());
+                await PostAsync(t => t.AllowStop(), this).ConfigureAwait(false);


Won't this prevent StopAsync from completing if the event loop is deadlocked?

Yes, it will. I'll add a check in AllowStop itself. It's safer.

What's the benefit of PostAsync here if we are waiting for _threadTcs.Task to complete anyway?

halter73 · 2017-04-21T17:42:15Z

src/Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv/LibuvTransport.cs

@@ -123,7 +123,7 @@ await Task.WhenAll(Threads.Select(thread => thread.StopAsync(TimeSpan.FromSecond
        {
            var disposeTasks = _listeners.Select(listener => listener.DisposeAsync()).ToArray();

-            if (!await WaitAsync(Task.WhenAll(disposeTasks), TimeSpan.FromSeconds(2.5)).ConfigureAwait(false))
+            if (!await WaitAsync(Task.WhenAll(disposeTasks), TimeSpan.FromSeconds(5)).ConfigureAwait(false))


Did you see this being timed out?

halter73 · 2017-04-21T18:04:33Z

Use PostAsync to observe ObjectDisposedExceptions in the shutdown sequence

Do you have any evidence that the ODEs are coming from AllowStop, OnStopRude or OnStopImmediate?

davidfowl · 2017-04-21T20:12:05Z

Spoke to @halter73 about this and decided to just remove the unreference from AllowStopRude

davidfowl · 2017-04-22T07:14:24Z

{System.ObjectDisposedException: Safe handle has been closed
   at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)
   at System.StubHelpers.StubHelpers.SafeHandleAddRef(SafeHandle pHandle, Boolean& success)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.NativeMethods.uv_unref(UvHandle handle)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.unref(UvHandle handle)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvHandle.Unreference()
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvThread.OnStopRude()
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvThread.<>c.<StopAsync>b__39_1(LibuvThread t)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvThread.CallbackAdapter`1.<>c.<.cctor>b__3_0(Object callback, Object state)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvThread.DoPostWork()}

Tweak libuv shutdown sequence

2bf0c9c

- Increase timeouts for thread and listener shutdowns - Use PostAsync to observe ObjectDisposedExceptions in the shutdown sequence

davidfowl requested a review from halter73 April 21, 2017 16:58

dnfclas added the cla-already-signed label Apr 21, 2017

halter73 reviewed Apr 21, 2017

View reviewed changes

Revert PostAsync and remove Unreference from OnStopRude

7316268

davidfowl merged commit feb9d12 into dev Apr 21, 2017

davidfowl deleted the davidfowl/test-reliability branch April 25, 2017 00:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak libuv shutdown sequence #1735

Tweak libuv shutdown sequence #1735

davidfowl commented Apr 21, 2017

halter73 Apr 21, 2017

davidfowl Apr 21, 2017

halter73 Apr 21, 2017

halter73 Apr 21, 2017

davidfowl Apr 21, 2017

halter73 commented Apr 21, 2017

davidfowl commented Apr 21, 2017

davidfowl commented Apr 22, 2017

Tweak libuv shutdown sequence #1735

Tweak libuv shutdown sequence #1735

Conversation

davidfowl commented Apr 21, 2017

halter73 Apr 21, 2017

Choose a reason for hiding this comment

davidfowl Apr 21, 2017

Choose a reason for hiding this comment

halter73 Apr 21, 2017

Choose a reason for hiding this comment

halter73 Apr 21, 2017

Choose a reason for hiding this comment

davidfowl Apr 21, 2017

Choose a reason for hiding this comment

halter73 commented Apr 21, 2017

davidfowl commented Apr 21, 2017

davidfowl commented Apr 22, 2017