This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Throw if UseUrls specifies HTTPS or path base (#1519) #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
Mar 21, 2017
| { | ||
| throw new InvalidOperationException($"HTTPS addresses are not supported. Use {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}() to configure an HTTPS endpoint."); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(parsedAddress.PathBase)) |
There was a problem hiding this comment.
What happens if it's just '/'?
Where does it throw? This just logs.
There was a problem hiding this comment.
There's a ServerAddress test that checks that just '/' is not set as path base:
halter73
suggested changes
Mar 22, 2017
| @@ -164,9 +164,14 @@ public void Start<TContext>(IHttpApplication<TContext> application) | |||
| { | |||
| var parsedAddress = ServerAddress.FromUrl(address); | |||
|
|
|||
| if (parsedAddress.Scheme.Equals("https", StringComparison.OrdinalIgnoreCase)) | |||
| { | |||
| throw new InvalidOperationException($"HTTPS addresses are not supported. Use {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}() to configure an HTTPS endpoint."); | |||
There was a problem hiding this comment.
I don't like the phrasing of "HTTPS addresses are not supported..."
I would change this to "HTTPS endpoints may only be configured using {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}()".
|
@halter73 I've changed the path base message too, for consistency. |
|
Does this incidentally fix #1296 too? |
|
@natemcmaster No. See my updated comment there. |
|
Updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1519