Add back the DisplayName setting

[Tratcher]

#391 @PinpointTownes @DamianEdwards

[HaoK]

Should just default this to the scheme like everything else to be consistent: IISDefaults.AuthenticationScheme. We don't suffix anything else with Auth today

[kevinchalet]

Not sure about that. Do you want the Windows scheme to be included by default in the "providers list"?

Pretty sure this has already been discussed in the past.

[Tratcher]

Yeah, it's null to avoid showing up by default. This is just the sample.

[kevinchalet]

@Tratcher thanks!

Did you consider directly exposing AuthenticationSchemeBuilder so you could also change the scheme name?

Something like:

public AuthenticationSchemeBuilder Scheme { get; } = new AuthenticationSchemeBuilder
{
    HandlerType = typeof(AuthenticationHandler),
    Name = IISDefaults.AuthenticationScheme
};

services.Configure<IISOptions>(options =>
{
    options.Scheme.DisplayName = "Intranet";
});

[HaoK]

That seems more dangerous, I don't think we want to allow people to change the HandlerType at all

[Tratcher]

That's interesting, bug I agree exposing the handler would be problematic.

[HaoK]

I don't think making the scheme name configurable is that critical, but if we want to expose that as well, its harmless and matches what Security auth does

[kevinchalet]

Well, if that's your only concern, you still can add a check to ensure the type wasn't changed before calling Buid():

if (!typeof(AuthenticationHandler).IsAssignableFrom(_options.Scheme.HandlerType))
{
    throw new InvalidOperationException("You're doing something wrong, bro'.");
}

[HaoK]

That just seems like a more error prone alternative to exposing only AuthenticationScheme / DisplayName

[Tratcher]

The structure would be nice..

[kevinchalet]

Sure. But that was a clever way to save one property while adopting the same pattern as the one you've used for CookieBuilder...

[HaoK]

Yeah but unlike CookieBuilder, the Handler IS the main thing, so throwing when you set that defeats the whole purpose of exposing that.

[HaoK]

I would go minimal, we can always add the builder later if things get more complicated.