Skip to content
This repository was archived by the owner on Nov 1, 2018. It is now read-only.

[HttpPlatformHandler]: Forward common headers from reverse proxy #2

Closed
Tratcher opened this issue Sep 27, 2015 · 11 comments
Closed

[HttpPlatformHandler]: Forward common headers from reverse proxy #2

Tratcher opened this issue Sep 27, 2015 · 11 comments

Comments

@Tratcher
Copy link
Member

From @davidfowl on September 11, 2015 16:11

This bug is to track the work that needs to happen so that items forwarded from httpplatformhandler show up in the user's application.

There are several parts to this:

  • Windows Auth (coming soon)
  • Client certs (not yet available)
  • Https scheme

We could do some of it in middleware (like WindowsAuth) but that would mean it wouldn't work out of the box. It could also be in the template by default so that we don't couple to the HttpPlatformHandler in any of our core components.

Copied from original issue: aspnet/Hosting#349

@Tratcher
Copy link
Member Author

Also of interest are the remote ip & port and the reverse proxy public IP & port. I'd recommend doing it all in middleware.

Eventually we'll need the TLS token binding.

@Tratcher
Copy link
Member Author

From @davidfowl on September 11, 2015 16:41

I think scheme is the only one we'd want to support by default.

@Tratcher
Copy link
Member Author

HttpPlatformHandler needs to forward them all, it's up to the app how many forwarders they check.

@Tratcher
Copy link
Member Author

From @davidfowl on September 11, 2015 17:13

We'll let the user experience drive that. This is our new ootb experience for IIS and it can't be degraded in obvious ways. We'll discuss it in the design meeting

@Tratcher
Copy link
Member Author

A few other interop questions:
100-continue support
http/2 termination (should just work, it happens in http.sys)
client disconnects

@Tratcher
Copy link
Member Author

From @davidfowl on September 15, 2015 3:43

We decided to make this a separate middleware UseHttpPlatformHandler(). The middleware may reuse the forwarding middleware as the Http platform handler uses some of the standard headers X-Forward-For and X-Forward-Proto.

This middleware also needs to handle windows auth via the X-IIS-WindowsAuthToken header. The value is a hex value that represents the primary user token (see https://msdn.microsoft.com/en-us/library/ms692659(v=vs.90).aspx). We have to close the handle on the way out since it's duped per request. The token is represented in the header by a hex value.

@Tratcher
Copy link
Member Author

From @rubenprins on September 16, 2015 17:39

What about nested applications/child paths? Is that still something that will be supported out of the box? Or will we need to configure the application's base path (a.k.a. ~/) manually?

@Tratcher
Copy link
Member Author

From @davidfowl on September 16, 2015 17:51

Won't be supported out of the box. I haven't tried it myself with the platform handler.

@Tratcher
Copy link
Member Author

@Eilon @muratg Let's create a new repo for this: IIS or IISIntegration. I think it will just replace Helios in the build hierarchy.

@Tratcher
Copy link
Member Author

@davidfowl repo name?

@Tratcher
Copy link
Member Author

From @davidfowl on September 27, 2015 5:7

@Tratcher move this bug over

@Tratcher Tratcher added this to the 1.0.0-beta8 milestone Sep 27, 2015
jkotalik pushed a commit that referenced this issue Mar 2, 2018
# This is the 1st commit message:

fix app recycle logic

# The commit message #2 will be skipped:

# adding parallel shutdown logic

# The commit message #3 will be skipped:

# some update

# The commit message #4 will be skipped:

# more change

# The commit message #5 will be skipped:

# close hkey

# The commit message #6 will be skipped:

# update logging

# The commit message #7 will be skipped:

# remove unused code

# The commit message #8 will be skipped:

# format change

# The commit message #9 will be skipped:

# exclude not-subapp case while sudstring does match
# Please enter the commit message for your changes. Lines starting
jkotalik added a commit that referenced this issue Apr 5, 2018
# This is the 1st commit message:

Add gtest!

# The commit message #2 will be skipped:

# still plumming gtest stuff, TODO consider just cloning the gTestRepo.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant