This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Use IHostingEnvironment to determine application identifier #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2017
Tratcher
suggested changes
Jun 2, 2017
|
|
||
| if (discriminator == null) | ||
| { | ||
| discriminator = services.GetService<IHostingEnvironment>()?.ContentRootPath; |
There was a problem hiding this comment.
I liked the new implementation better. Rather than explicitly calling out to IHostingEnvironment, instead register an IApplicationDiscriminator that does it.
|
🆙 📅 |
Tratcher
approved these changes
Jun 2, 2017
Reverses changes made in #230
natemcmaster
force-pushed
the
namc/flop-flip
branch
from
f9e047f to
285b973
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverses changes made in #230, which were originally made because hosting was not going to support ns2.0.
Expect a hosting PR too soon.