refactor: consider json a js source (if resolve_json_module) #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative to #320 that doesn't break or fix anything. |
|
I've forgotten all of the context on json inputs to ts_projects.... but if we're pushing to 2.0 @alexeagle we should look at this again and understand the change in this PR |
This allows us to use the _out_paths machinery for json sources as well. To achieve this, we add a resolve_json_module parameter to relevant methods in ts_lib (ts_lib is private so this is a backwards compatible change). There are two small side-effects to this refactor: - We use _lib.relative_to_package rather than a prefix removal. - json inputs that are not sources and do not have an input / output collision are now declared.
alexeagle
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use the _out_paths machinery for json sources as well.
To achieve this, we add a resolve_json_module parameter to relevant methods in ts_lib (ts_lib is private so this is a backwards compatible change).
There are two small side-effects to this refactor: