Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ProtocResolver.java warnings #509

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Dec 26, 2024

  • Rewrite Termux warning to be clearer.
  • Convert "LATEST" exception into a warning to be more permissive.

- Rewrite Termux warning to be clearer.
- Convert "LATEST" exception into a warning to be more permissive.
@ascopes ascopes added this to the v2.9.x milestone Dec 26, 2024
@ascopes ascopes self-assigned this Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (0326e60) to head (3b89baa).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...pes/protobufmavenplugin/protoc/ProtocResolver.java 33.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          40       40           
  Lines        1312     1312           
  Branches       89       89           
=======================================
  Hits         1149     1149           
  Misses        122      122           
  Partials       41       41           
Files with missing lines Coverage Δ
...pes/protobufmavenplugin/protoc/ProtocResolver.java 70.28% <33.34%> (ø)

@ascopes ascopes merged commit 59224d0 into main Dec 26, 2024
12 of 13 checks passed
@ascopes ascopes deleted the task/improve-protoc-resolution-warnings branch December 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant