Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-24: Add ability to generate gRPC stubs #25

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Nov 26, 2023

Adds ability to generate gRPC stubs for Java and optionally Kotlin by resolving the binaries from Maven central.

The plugin structure has been moved around to enable reusing components more easily.

Closes GH-24.

@ascopes ascopes added documentation Improvements or additions to documentation enhancement labels Nov 26, 2023
@ascopes ascopes added this to the 0.0.1-M3 milestone Nov 26, 2023
@ascopes ascopes self-assigned this Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (2ecc8e8) 36.33% compared to head (66844ca) 29.51%.

Files Patch % Lines
.../protobufmavenplugin/generate/SourceGenerator.java 0.00% 51 Missing ⚠️
...opes/protobufmavenplugin/AbstractGenerateMojo.java 0.00% 11 Missing ⚠️
...lve/grpc/MavenGrpcJavaPluginCoordinateFactory.java 0.00% 9 Missing ⚠️
...e/grpc/MavenGrpcKotlinPluginCoordinateFactory.java 0.00% 9 Missing ⚠️
...obufmavenplugin/execute/ProtocArgumentBuilder.java 0.00% 8 Missing ⚠️
...ufmavenplugin/generate/SourceGeneratorBuilder.java 0.00% 5 Missing ⚠️
...lugin/resolve/grpc/PathGrpcJavaPluginResolver.java 0.00% 3 Missing ⚠️
...gin/resolve/grpc/PathGrpcKotlinPluginResolver.java 0.00% 3 Missing ⚠️
...opes/protobufmavenplugin/GenerateProtobufMojo.java 0.00% 2 Missing ⚠️
.../protobufmavenplugin/GenerateProtobufTestMojo.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #25      +/-   ##
============================================
- Coverage     36.33%   29.51%   -6.82%     
  Complexity       64       64              
============================================
  Files            18       24       +6     
  Lines           355      437      +82     
  Branches         23       29       +6     
============================================
  Hits            129      129              
- Misses          225      307      +82     
  Partials          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascopes ascopes merged commit 192f148 into main Nov 26, 2023
@ascopes ascopes deleted the feature/GH-24-grpc-stubs branch November 26, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support gRPC stub generation
1 participant