Adjust feedback for algorithm 32 in Mk I engine #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing the feedback value up to 7 in algorithm 32 results in digital noise, see issue asb2m10#146. That's not how the original DX7 behaves. This patch tries to fix this issue by scaling the feedback value for algorithm 32. It sounds much closer to the (at least my) DX7 Mk I and doesn't produce the digital noise any more. In direct comparison, at feedback value 7 it sounds a bit brighter than my original DX7. I tried different scalings (e.g. feedback_shift+3) which sounded a bit too muffled. So overall (feedback_shift+2) sounds closest to my DX7. This might need further investigaion but for now I think that this scaling is much better than the digital noise currently produced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing the feedback value up to 7 in algorithm 32 results in digital noise, see issue #146.
That's not how the original DX7 behaves.
This patch tries to fix this issue by scaling the feedback value for algorithm 32. It sounds
much closer to the (at least my) DX7 Mk I and doesn't produce the digital noise any more.
In direct comparison, at feedback value 7 it sounds a bit brighter than my original DX7.
I tried different scalings (e.g. feedback_shift+3) which sounded a bit too muffled.
So overall (feedback_shift+2) sounds closest to my DX7.
This might need further investigaion but for now I think that this scaling is much better than
the digital noise currently produced.