Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support specific framework & plugin in scanner #158

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented Aug 1, 2022

此 PR 旨在允许通过 scanner 扫描时指定框架和插件列表来启动应用:

  • scanner 声明了框架配置,则用户在应用中配置的框架声明不再生效,以 scanner 指定为准
  • scanner 声明了插件配置,则会使用这一插件配置以 deepmerge 的方式覆盖掉用户在应用中声明的插件配置

这样设计的目的是给工具链更大的灵活性,比如用户可以无需每次都要显式指定框架,工具链在调用 scanner 构建期指定框架使得应用可以部署到不同的环境中,比如 #111 中提到的需求可以使用此泛用性更好的方式来优雅解决

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #158 (31b76c2) into master (df834fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   89.25%   89.28%   +0.02%     
==========================================
  Files          51       51              
  Lines        1089     1092       +3     
  Branches      178      179       +1     
==========================================
+ Hits          972      975       +3     
  Misses        117      117              
Impacted Files Coverage Δ
src/scanner/scan.ts 94.96% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df834fc...31b76c2. Read the comment docs.

Copy link
Member

@noahziheng noahziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyj1991 hyj1991 merged commit e42f6bf into artusjs:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Scanner 需要支持指定应用直接的框架 [RFC] 支持指定默认的 “Base” Framework
3 participants