-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support inject in lifecycle #145
Conversation
之前专门为 lifecycle 实现的装饰器貌似可以移除了 |
现在是存储 lifecycle 的 class 吧?看起来不能移除 |
WithApplication , WithContainer 这几个好像是 lifecycyle 专用吧 |
对,这两个是可以去掉了,稍后我再改下 |
这个进度如何了,什么时候可以合并 |
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 89.44% 89.25% -0.19%
==========================================
Files 51 51
Lines 1108 1089 -19
Branches 182 178 -4
==========================================
- Hits 991 972 -19
Misses 117 117
Continue to review full report at Codecov.
|
cc @noahziheng @JerrysShan ,合并了 master,去除了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好像没有在 set 的时候用上 lazy?@hyj1991 @JerrysShan
我确认下 lazy set 如何实现的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref: #143