Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove all yaml meta file, change them to JSON #138

Merged
merged 3 commits into from
Jul 14, 2022
Merged

feat: remove all yaml meta file, change them to JSON #138

merged 3 commits into from
Jul 14, 2022

Conversation

noahziheng
Copy link
Member

resolve #137

hyj1991
hyj1991 reviewed Jul 14, 2022
View reviewed changes
hyj1991
hyj1991 reviewed Jul 14, 2022
View reviewed changes
@hyj1991
Copy link
Member

hyj1991 commented Jul 14, 2022

load meta 没必要加这些判断，参数也不需要 extname，简单一些：

  • 拼接 meta.json / exception.json
  • 判断是否存在
  • require

@noahziheng
Copy link
Member Author

@hyj1991 修改了一下 PTAL

  • 无需在 loadMetaFile 中判断是否存在，import 会做，同样是抛 No such file 错误

fengmk2
fengmk2 reviewed Jul 14, 2022
View reviewed changes
exception.json
@@ -0,0 +1,13 @@
{
"ARTUS:GLOBAL_TEST": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样对比看，我觉得还是 JSON 适合 js 程序员。

@hyj1991 hyj1991 merged commit 8392260 into artusjs:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 left review comments

@hyj1991 hyj1991 hyj1991 approved these changes

@Beace Beace Awaiting requested review from Beace

@JerrysShan JerrysShan Awaiting requested review from JerrysShan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] 为 Plugin/Framework 提供入口模块用于元信息声明
3 participants
@noahziheng @hyj1991 @fengmk2