Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

[Dev] Brings back storybooks for dev #trivial #585

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Conversation

orta
Copy link
Contributor

@orta orta commented Jun 5, 2017

I assume during debugging the latest react native update storybooks were removed and then not replaced afterwards, see discussion at https://github.com/artsy/emission/pull/570/files#r120094031

As I was touching it, I updated us to the latest stable release of storybooks too. 👍


Tested on Device?

How to get set up with this PR?

 

To run on your computer:

git fetch origin pull/585/head:orta-585-checkout
git checkout orta-585-checkout
yarn install
cd example; pod install; cd ..
open -a Simulator
yarn start

Then run xcrun simctl launch booted net.artsy.Emission once a the simulator has finished booting

To run inside Eigen (prod or beta) or Emission (beta): Shake the phone to get the Admin menu.

If you see "Use Staging React Env" - click that and restart, then follow the next step.

Click on "Choose an RN build" - then pick the one that says: "X,Y,Z"

Note: this is a TODO for PRs, currently you can only do it on master commits.

@orta orta mentioned this pull request Jun 5, 2017
10 tasks
@mennenia
Copy link
Contributor

mennenia commented Jun 5, 2017

👍 good spot!

@mennenia mennenia merged commit 79db9bd into master Jun 5, 2017
@orta orta deleted the storybooks-r16 branch June 5, 2017 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants