This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[Dev] Brings back storybooks for dev #trivial #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume during debugging the latest react native update storybooks were removed and then not replaced afterwards, see discussion at https://github.com/artsy/emission/pull/570/files#r120094031
As I was touching it, I updated us to the latest stable release of storybooks too. 👍
Tested on Device?
How to get set up with this PR?
To run on your computer:
Then run
xcrun simctl launch booted net.artsy.Emission
once a the simulator has finished bootingTo run inside Eigen (prod or beta) or Emission (beta): Shake the phone to get the Admin menu.
If you see "Use Staging React Env" - click that and restart, then follow the next step.
Click on "Choose an RN build" - then pick the one that says: "X,Y,Z"
Note: this is a TODO for PRs, currently you can only do it on master commits.