Raspbery Pi: legacy kernel is missing support for CONFIG_FW_LOADER_COMPRESS

[igorpecovnik]

Description

Fixing a bug that failed to load some firmware files.

How Has This Been Tested?

https://forum.armbian.com/topic/50287-armbian-unofficial_24110-trunk_rpi4b_jammy_current_6678_minimal-not-fond-wifi/

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[pyavitz]

He was using Legacy 6.6.y and that defconfig appears to be missing

CONFIG_FW_LOADER_COMPRESS=y
CONFIG_FW_LOADER_COMPRESS_ZSTD=y

During my discussion with him I asked him to take note of the current firmware installed

UPEX:~# ls -la /lib/firmware/brcm/brcmfmac43455-sdio*
lrwxrwxrwx 1 root root  35 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.bin.zst -> ../cypress/cyfmac43455-sdio.bin.zst
lrwxrwxrwx 1 root root  40 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.clm_blob.zst -> ../cypress/cyfmac43455-sdio.clm_blob.zst
lrwxrwxrwx 1 root root  35 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.bin.zst -> ../cypress/cyfmac43455-sdio.bin.zst
lrwxrwxrwx 1 root root  40 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.clm_blob.zst -> ../cypress/cyfmac43455-sdio.clm_blob.zst
lrwxrwxrwx 1 root root  26 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt.zst -> brcmfmac43455-sdio.txt.zst
lrwxrwxrwx 1 root root  35 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin.zst -> ../cypress/cyfmac43455-sdio.bin.zst
lrwxrwxrwx 1 root root  40 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.clm_blob.zst -> ../cypress/cyfmac43455-sdio.clm_blob.zst
lrwxrwxrwx 1 root root  26 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt.zst -> brcmfmac43455-sdio.txt.zst
lrwxrwxrwx 1 root root  35 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.bin.zst -> ../cypress/cyfmac43455-sdio.bin.zst
lrwxrwxrwx 1 root root  40 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.clm_blob.zst -> ../cypress/cyfmac43455-sdio.clm_blob.zst
lrwxrwxrwx 1 root root  26 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.txt.zst -> brcmfmac43455-sdio.txt.zst
lrwxrwxrwx 1 root root  35 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.bin.zst -> ../cypress/cyfmac43455-sdio.bin.zst
lrwxrwxrwx 1 root root  40 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.clm_blob.zst -> ../cypress/cyfmac43455-sdio.clm_blob.zst
lrwxrwxrwx 1 root root  26 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt.zst -> brcmfmac43455-sdio.txt.zst
lrwxrwxrwx 1 root root  35 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.bin.zst -> ../cypress/cyfmac43455-sdio.bin.zst
lrwxrwxrwx 1 root root  40 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.clm_blob.zst -> ../cypress/cyfmac43455-sdio.clm_blob.zst
lrwxrwxrwx 1 root root  26 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.txt.zst -> brcmfmac43455-sdio.txt.zst
-rw-r--r-- 1 root root 972 Apr 10  2024 /lib/firmware/brcm/brcmfmac43455-sdio.txt.zst

So technically the correct firmware was in place, but the kernel didn't support the compression format.

The PR fixes the issue regardless, but now doubles up on the firmware installed. You may want to consider not installing the ubuntu firmware if possible?

[igorpecovnik]

So best way from this to keep INSTALL_ARMBIAN_FIRMWARE=no and enable

CONFIG_FW_LOADER_COMPRESS=y
CONFIG_FW_LOADER_COMPRESS_ZSTD=y

in the legacy (6.6.y) kernel build?

For disabling ubuntu packages I would need to inspect each of one to be sure. Its a bit confusing that this was designed to work with Ubuntu kernel and firmware right from start.

[pyavitz]

So best way from this to keep INSTALL_ARMBIAN_FIRMWARE=no and enable

CONFIG_FW_LOADER_COMPRESS=y CONFIG_FW_LOADER_COMPRESS_ZSTD=y

in the legacy (6.6.y) kernel build?

I think so, yes.