cli: Add command "dts-check" to validate dts files and improve board & patch development overall #6482
+74
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No new major versions
Validates the dts/dtb file for the selected board and outputs the validation logs to the user. This can be used when adding a new board, developing or improving a dts file. Should lead to higher quality device trees and patches overall, if used.
github-actions
bot
added
size/medium
igorpecovnik
approved these changes
Apr 26, 2024
igorpecovnik
added
Ready to merge
|
Does not build https://paste.armbian.com/patunibuki |
|
Maybe we need to update setuptools for python3. |
|
Looks like something else ... :( |
didierjoomun
added a commit
to didierjoomun/documentation
that referenced
this pull request
May 18, 2024
igorpecovnik
added a commit
to armbian/documentation
that referenced
this pull request
May 30, 2024
* Modified warning message and added "DEPRECATED" in the title of the page. * Added the follwping PRs to the documentation (/Developer-Guide_Build-Options/): - armbian/build#6482 - armbian/build#6376 and armbian/build#6392 - armbian/build#6354 - armbian/build#6353 * Update Developer-Guide_Build-Options.md --------- Co-authored-by: Igor <igor@armbian.com>
11 tasks
ColorfulRhino
added
Documentation finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new command can be used like this:
It validates the dts/dtb file for the selected board against dt bindings and outputs the validation logs to the user.
This can be used when adding a new board, developing or improving a dts file. Should lead to higher quality device trees and patches overall, if used.
Documentation summary for feature
cli: Add command "dts-check" to validate dts files and improve board & patch development overall
This command validates the dts/dtb file for the selected board against device tree bindings and outputs the validation logs to the user.
It can be used when adding a new board, developing or improving a dts file. Should lead to higher quality device trees and patches overall, if used.
Then wait for the validation to finish and check the output. If there is anything wrong with your board's device tree, you will see errors or warnings in the log. Analyze them carefully and use this information to improve your dts file.
Please note: Errors or warnings can also be introduced by SoC/board patches. When patching in new functions, like crypto for the RK3588, not only add the relevant parts to rk3588s.dtsi, but also try to add the device tree bindings in
linux/Documentation/devicetree/bingings/for validation.How Has This Been Tested?
./compile.sh BOARD=nanopi-r5c BRANCH=edge dts-checkChecklist: