Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BananaPi CM4/M2S: FIXUPS #6456

Merged
merged 1 commit into from
Apr 1, 2024
Merged

BananaPi CM4/M2S: FIXUPS #6456

merged 1 commit into from
Apr 1, 2024

Conversation

pyavitz
Copy link
Collaborator

@pyavitz pyavitz commented Apr 1, 2024 •
edited by jira bot
Loading

BPI-CM4
No change in functionality.

BPI-M2S
The fan on the unit is constantly running. So lets set thermal trip points and add the ability to control when we want it to kick on. By default it is set to power on at 60*C.

AR-2234

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

BananaPi CM4/M2S: FIXUPS
fcdcd34 
BPI-CM4
No change in functionality. Fixup adjustments.

BPI-M2S
The fan on the unit is constantly running. So lets set thermal
trip points and add the ability to control when we want it to
kick on. By default it is set to power on at 60*C.

Signed-off-by: Patrick Yavitz <pyavitz@xxxxx.com>
@pyavitz pyavitz requested a review from igorpecovnik as a code owner April 1, 2024 12:50
@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... labels Apr 1, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release labels Apr 1, 2024
@igorpecovnik igorpecovnik merged commit 0b7af65 into armbian:main Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@rpardini rpardini Awaiting requested review from rpardini rpardini is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@SteeManMI SteeManMI Awaiting requested review from SteeManMI SteeManMI is a code owner

@adeepn adeepn Awaiting requested review from adeepn adeepn is a code owner

Assignees
No one assigned
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyavitz @igorpecovnik