Move curves to algebra #680 #701
Conversation
z-tech
added
the
do-not-merge-now
z-tech
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
This comment was marked as outdated.
This comment was marked as outdated.
|
CI is passing. Shall we merge? (we ideally should merge soon so we are not keeping both) |
curves/LICENSE-APACHE
Outdated
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
Let's make this a pointer to the top level LICENSE-APACHE
There was a problem hiding this comment.
are symlinks fine? I forget if there's a GitHub specific way to do this
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
|
thank you for taking on this painful task |
z-tech
removed
the
do-not-merge-now
| - id: set-dirs # Give it an id to handle to get step outputs in the outputs key above | ||
| run: | | ||
| # shellcheck disable=SC2086 | ||
| echo "dir=$(find . -mindepth 1 -maxdepth 1 -type d | jq -R -s -c 'split("\n")[:-1]')" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
If anyone knows how to fix this without the ignore LMK
.github/workflows/ci.yml:184:9: shellcheck reported issue in this script: SC2086:info:1:90: Double quote to prevent globbing and word splitting [shellcheck]
|
Seems pretty much ready to me. LMK what you all think. |
|
I see I have one review but I just want to confirm it's okay to merge or if we should wait for some reason thx 😅 |
Move curves to algebra
Just moves curves into this repo. They remain separate workspaces.
closes: #680
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer