Refactor(eos_designs): structured_config for core_interfaces_and_l3_edge router_bgp #5063
+44
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5063
# Activate the virtual environment
source test-avd-pr-5063/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@refactor_core_interfaces_router_bgp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,refactor_core_interfaces_router_bgp --force
# Optional: Install AVD examples
cd test-avd-pr-5063
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
force-pushed
the
refactor_core_interfaces_router_bgp
branch
from
7d63ac8 to
606d57e
Compare
github-actions
bot
added
the
state: CI Updated
Vibhu-gslab
force-pushed
the
refactor_core_interfaces_router_bgp
branch
from
bfb05ee to
03b70e4
Compare
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/router_bgp.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/router_bgp.py
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
refactor_core_interfaces_router_bgp
branch
from
cbd8c4b to
01a08ec
Compare
laxmikantchintakindi
force-pushed
the
refactor_core_interfaces_router_bgp
branch
from
8d08efb to
5b846d1
Compare
laxmikantchintakindi
approved these changes
Feb 20, 2025
Vibhu-gslab
changed the title
Vibhu-gslab
force-pushed
the
refactor_core_interfaces_router_bgp
branch
from
5b846d1 to
e3e1a27
Compare
ClausHolbechArista
requested changes
Feb 21, 2025
| Found duplicate objects with conflicting data while generating configuration for Ethernet Interfaces defined under l3_edge p2p_link. | ||
| {'name': 'ethernet1', 'peer': 'peer2', 'peer_interface': 'ethernet2', 'description': 'P2P_peer2_ethernet2'} conflicts with | ||
| {'name': 'ethernet1', 'peer': 'peer1', 'peer_interface': 'ethernet1', 'description': 'P2P_peer1_ethernet1'}. | ||
| Found duplicate objects with conflicting data while generating configuration for Neighbors. {'ip_address': '192.168.0.3', |
There was a problem hiding this comment.
This is detecting duplicate BGP neighbors now, where before it was checking for duplicate interfaces. Please revert and add another test for duplicate neighbors. Thanks.
There was a problem hiding this comment.
same for core-interface variant
There was a problem hiding this comment.
Fixed error message.
| @@ -33,6 +33,7 @@ core_interfaces: | |||
| interfaces: [ Ethernet1, Ethernet2 ] | |||
| profile: isis_bb_profile | |||
| ip: ["unnumbered loopback0", "unnumbered loopback0"] | |||
| as: [65000, 65002] | |||
There was a problem hiding this comment.
why do we need to add AS and IP info here?
There was a problem hiding this comment.
We were getting the below errors and molecule was failing
{"changed": false, "msg": "core_interfaces.p2p_links.[].as or core_interfaces.p2p_links_profiles.[].as”}
{"changed": false, "msg": "core_interfaces.p2p_links.[].ip, .subnet or .ip_pool"}
There was a problem hiding this comment.
it should be possible to not set AS so lets make sure the behavior is not changing
|
|
||
| # RFC5549 | ||
| if self.inputs.underlay_rfc5549 and p2p_link.routing_protocol != "ebgp": | ||
| neighbor_interfaces.append({"name": p2p_link_data["interface"], **neighbor}) | ||
| self.structured_config.router_bgp.neighbor_interfaces.append_new(name=p2p_link_data["interface"], **neighbor._as_dict()) |
There was a problem hiding this comment.
We should avoid going to dict at all.
It will be simpler to just build the full neighbor interface here setting the 5 arguments directly.
And then remove the neighbor = stuff below this if so it only runs when building a regular neighbor.
Alternative is to use _cast_as
Vibhu-gslab
force-pushed
the
refactor_core_interfaces_router_bgp
branch
from
36e83d2 to
b79f7f1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_designs structured_config for core_interfaces_and_l3_edge router_bgp
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
How to test
Checklist
Repository Checklist