Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Add test catalog to verify active CVX connections #960

Merged
merged 13 commits into from
Dec 13, 2024

Conversation

sarunac
Copy link
Contributor

@sarunac sarunac commented Dec 9, 2024

Description

Verifies the number of active cvx connections to match the expected active cvx connections .

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@sarunac sarunac changed the title add test catalog to verify active cvx connections feat(anta): add test catalog to verify active cvx connections Dec 9, 2024
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #960 will not alter performance

Comparing sarunac:verifyCVXConnection (35263bc) with main (abf06b1)

Summary

✅ 8 untouched benchmarks

@gmuloc gmuloc changed the title feat(anta): add test catalog to verify active cvx connections feat(anta): Add test catalog to verify active cvx connections Dec 10, 2024
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments to simplify the python code

You will need to adjust the pytest when refactoring.

Also lets check on our call the revision of the command

sarunac and others added 3 commits December 10, 2024 07:41
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

sarunac and others added 7 commits December 12, 2024 12:27
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc changed the title feat(anta): Add test catalog to verify active cvx connections feat(anta): Add test catalog to verify active CVX connections Dec 12, 2024
@gmuloc gmuloc merged commit a11aca7 into aristanetworks:main Dec 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants