fix(anta.tests): First round of cleaning up BGP tests module

[carl-baillargeon]

Description

Refactoring BGP tests module to address the following issues:

• Refactor to reduce the number of lines in bgp test module #865
• Extra attributes should be forbidden in nested Input models #809
• Extend VerifyBGPPeerCount or VerifyBGPPeersHealth test to also checks for a minimum established time for BGP session #635
• Have nicer result failure messages #587
• Enhancement: Input subclasses refactoring #388

Focusing on VerifyBGPPeerCount, VerifyBGPPeersHealth, VerifyBGPSpecificPeers

Task list:

• Update unit tests for VerifyBGPPeersHealth & VerifyBGPSpecificPeers
  • Success
  • VRF not configured
  • No peers found
  • Session not established
  • AFI/SAFI not negotiated
  • TCP session queues not empty if check_tcp_queues is True
• Add unit tests for check_bgp_neighbor_capability (IMP: Added unit tests in test_tools.)
• Add unit tests for format_data

Changes

• Updated InQ & OutQ steps as or evaluates lazily, meaning if the first part (InQ := value) != 0 is True, the second part (OutQ := value) != 0 will not be evaluated, results OutQ is never assigned, leading to a NameError.
• In VerifyBGPSpecificPeers test, added check for peers have correct AFI/SAFI negotiated.
• Added _check_bgp_neighbor_capability to bgp module as intended to BGP module only.

[codspeed-hq]

CodSpeed Performance Report

Merging #888 will not alter performance

_{Comparing carl-baillargeon:feat/bgp_modules (b76236a) with main (8ac4477)}

Summary

✅ 8 untouched benchmarks

[gmuloc]

This PR seems quite breaking for the tests as we are suddenly checking more things.
to get a success like Count is now dpeendent on the state of the peer when it did not used to be.

Ideally we could add a flag for this one to not be concerned with the the state (default being we are not) to be backward compatible

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud