Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Updated VerifyBFDPeersIntervals for failure message to be in milliseconds like the inputs #805

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

In eAPI reports the interval timers are in microseconds instead of milliseconds so converted timers in to milliseconds to be consistent with the inputs.

Fixes #799

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft August 29, 2024 04:15
Copy link

@vitthalmagadum vitthalmagadum requested a review from gmuloc August 29, 2024 11:54
@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 29, 2024 12:33
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 30f731c into aristanetworks:main Aug 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifyBFDPeersIntervals failure message should be in milliseconds like the inputs
3 participants