Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta): Added support for dict commands in EapiCommandError #803

Merged
merged 8 commits into from
Aug 30, 2024
Merged

fix(anta): Added support for dict commands in EapiCommandError #803

merged 8 commits into from
Aug 30, 2024

Conversation

carl-baillargeon
Copy link
Contributor

Description

Fixes #718

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@carl-baillargeon carl-baillargeon merged commit 145b7c4 into aristanetworks:main Aug 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: fix(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: asynceapi EapiCommandError exception only supports complex commands (dict) and not simple commands (str)
2 participants
@carl-baillargeon @gmuloc