Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added test case to verify Link Aggregation Control Protocol (LACP) functionality #764

Merged
merged 8 commits into from
Sep 11, 2024
Merged

feat(anta): Added test case to verify Link Aggregation Control Protocol (LACP) functionality #764

merged 8 commits into from
Sep 11, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verify LACP functionality using show lacp interface .

  • Interface should be bundled in given port channel.
  • Aggregated link state should be active, LongTimeout( Indicates a longer interval for LACPDU transmission), Aggregable, InSync (Indicates actively participating in both transmit and receive operations), Collecting and Distributing (Indicates the interface is functioning correctly in aggregation group. i.e capable of receiving and sending the traffic.)

Fixes #762

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft July 24, 2024 05:09
MaheshGSLAB
MaheshGSLAB reviewed Aug 1, 2024
View reviewed changes
MaheshGSLAB
MaheshGSLAB reviewed Aug 14, 2024
View reviewed changes
MaheshGSLAB
MaheshGSLAB reviewed Aug 14, 2024
View reviewed changes
@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 16, 2024 09:40
carl-baillargeon
carl-baillargeon approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@carl-baillargeon carl-baillargeon merged commit 02e8491 into aristanetworks:main Sep 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test case to verify Link Aggregation Control Protocol (LACP) functionality
3 participants
@vitthalmagadum @carl-baillargeon @MaheshGSLAB