Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Add EapiRequest and EapiResponse models for asynceapi to support eAPI stopOnError and timestamps features #1060

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

carl-baillargeon
Copy link
Contributor

@carl-baillargeon carl-baillargeon commented Mar 3, 2025

Description

Adding internal modules to asynceapi to support request/response models when executing commands on eAPI. _execute method has been added in Device to use these new models.

The goal is to have a consistent response model with whatever eAPI JSON-RPC params we use in the requests.

New models now support timestamps and stopOnError eAPI features properly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

…pporting stop_on_error and timestamps features
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #1060 will not alter performance

Comparing carl-baillargeon:feat/asynceapi_stop_on_error (0676432) with main (2672570)

Summary

✅ 22 untouched benchmarks

@carl-baillargeon carl-baillargeon marked this pull request as ready for review March 3, 2025 19:46
@carl-baillargeon carl-baillargeon requested a review from gmuloc March 3, 2025 19:46
Copy link

sonarqubecloud bot commented Mar 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant