refactor(anta.tests): Nicer result failure messages OSPF test module #1040
+130
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1040 will not alter performanceComparing Summary
|
vitthalmagadum
approved these changes
Feb 21, 2025
carl-baillargeon
requested changes
Feb 25, 2025
anta/tests/routing/ospf.py
Outdated
| f"Instance: {instance} VRF: {vrf} Interface: {interface[0]} - Incorrect adjacency state - Expected: Full Actual: {interface[1]}" | ||
| ) | ||
|
|
||
| # If OSPF neighbors are not configured on device, test fails. |
There was a problem hiding this comment.
Suggested change
| # If OSPF neighbors are not configured on device, test fails. | |
| # If OSPF neighbors are not configured on device, test is skipped. |
anta/tests/routing/ospf.py
Outdated
| no_neighbor = False | ||
| interfaces.extend([neighbor["routerId"] for neighbor in neighbors if neighbor["adjacencyState"] == "full"]) | ||
|
|
||
| # If OSPF neighbors are not configured on device, test fails. |
There was a problem hiding this comment.
Suggested change
| # If OSPF neighbors are not configured on device, test fails. | |
| # If OSPF neighbors are not configured on device, test is skipped. |
examples/tests.yaml
Outdated
| @@ -661,7 +661,7 @@ anta.tests.routing.isis: | |||
| nexthop: 1.1.1.1 | |||
| anta.tests.routing.ospf: | |||
| - VerifyOSPFMaxLSA: | |||
| # Verifies all OSPF instances did not cross the maximum LSA threshold. | |||
| # Verifies LSAs present in the OSPF link state database did not cross the maximum LSA Threshold. | |||
There was a problem hiding this comment.
Let's keep the current one.
anta/tests/routing/ospf.py
Outdated
Comment on lines
159
to
161
| max_lsa = instance_data.get("maxLsaInformation", {}).get("maxLsa") | ||
| max_lsa_threshold = instance_data.get("maxLsaInformation", {}).get("maxLsaThreshold") | ||
| num_lsa = instance_data.get("lsaInformation", {}).get("numLsa") |
There was a problem hiding this comment.
You can use get_value here.
There was a problem hiding this comment.
Also, check in EOS CLI models if these keys could be missing, otherwise we can simply use instance_data["maxLsaThreshold"] like before.
anta/tests/routing/ospf.py
Outdated
| if num_lsa > max_lsa * (max_lsa_threshold / 100): | ||
| exceeded_instances.append(instance) | ||
| if exceeded_instances: | ||
| self.result.is_failure(f"Following OSPF Instances crossed the maximum LSA threshold - {', '.join(exceeded_instances)}") |
There was a problem hiding this comment.
Suggested change
| self.result.is_failure(f"Following OSPF Instances crossed the maximum LSA threshold - {', '.join(exceeded_instances)}") | |
| self.result.is_failure(f"Following OSPF instances crossed the maximum LSA threshold - {', '.join(exceeded_instances)}") |
Can we add some numbers here? Expected Actual?
geetanjalimanegslab
force-pushed
the
fix_ospf_module_failure_msg
branch
from
eda29fd to
76544e2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nicer result failure messages for following test module.
Fixes #587
Checklist:
pre-commit run)tox -e testenv)