Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Add timestamps option to asynceapi client and update typing #1035

Conversation

carl-baillargeon
Copy link
Contributor

@carl-baillargeon carl-baillargeon commented Feb 11, 2025

Description

Add timestamps option to asynceapi for eAPI requests. Also updated typing for asynceapi.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #1035 will not alter performance

Comparing carl-baillargeon:feat/asynceapi_typing_and_timestamps (405692f) with main (9ba0284)

Summary

✅ 22 untouched benchmarks

@carl-baillargeon carl-baillargeon merged commit 5a1e2a0 into aristanetworks:main Feb 27, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants