Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propagate context to AppController #21943

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sivchari
Copy link
Contributor

@sivchari sivchari commented Feb 22, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Replace context.TODO or context.Background.
The rest of the context.Background can be left as is.

@sivchari sivchari requested a review from a team as a code owner February 22, 2025 05:56
Copy link

bunnyshell bot commented Feb 22, 2025

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@sivchari sivchari changed the title propagate context to AppController fix: propagate context to AppController Feb 22, 2025
@sivchari sivchari changed the title fix: propagate context to AppController feat: propagate context to AppController Feb 22, 2025
@sivchari sivchari force-pushed the propagate-ctx-appctrl branch from c1966e5 to 37d9445 Compare February 22, 2025 08:51
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the propagate-ctx-appctrl branch from 37d9445 to cf3aa07 Compare February 22, 2025 09:01
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the failing tests?

@sivchari
Copy link
Contributor Author

Sure!
I'll do it by the end of today :)

Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the propagate-ctx-appctrl branch 3 times, most recently from f8a5ea0 to da23de5 Compare February 23, 2025 18:20
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 78.40909% with 19 lines in your changes missing coverage. Please review.

Project coverage is 53.87%. Comparing base (37aaeb3) to head (3d7ea31).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
controller/appcontroller.go 83.95% 10 Missing and 3 partials ⚠️
controller/hydrator/hydrator.go 20.00% 4 Missing ⚠️
controller/hydrator_dependencies.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21943      +/-   ##
==========================================
- Coverage   55.73%   53.87%   -1.87%     
==========================================
  Files         341      341              
  Lines       57004    56996       -8     
==========================================
- Hits        31773    30708    -1065     
- Misses      22587    23703    +1116     
+ Partials     2644     2585      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the propagate-ctx-appctrl branch from da23de5 to 3d7ea31 Compare February 23, 2025 19:00
@sivchari
Copy link
Contributor Author

@nitishfy
Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants