-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: propagate context to AppController #21943
base: master
Are you sure you want to change the base?
Conversation
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
c1966e5
to
37d9445
Compare
Signed-off-by: sivchari <shibuuuu5@gmail.com>
37d9445
to
cf3aa07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the failing tests?
Sure! |
Signed-off-by: sivchari <shibuuuu5@gmail.com>
f8a5ea0
to
da23de5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21943 +/- ##
==========================================
- Coverage 55.73% 53.87% -1.87%
==========================================
Files 341 341
Lines 57004 56996 -8
==========================================
- Hits 31773 30708 -1065
- Misses 22587 23703 +1116
+ Partials 2644 2585 -59 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sivchari <shibuuuu5@gmail.com>
da23de5
to
3d7ea31
Compare
@nitishfy |
Checklist:
Replace context.TODO or context.Background.
The rest of the context.Background can be left as is.