feat: add cluster-only uninstall option and resource deletion handling #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
Introduce a new flag `--clusterOnly` to the uninstall command, allowing direct uninstallation from the cluster without interacting with the git repository. Signed-off-by: Noam Gal <noam.gal@octopus.com>
Signed-off-by: Noam Gal <noam.gal@octopus.com>
Ensure that required flags are validated only when not fixed tests Signed-off-by: Noam Gal <noam.gal@octopus.com>
ATGardner
force-pushed
the
uninstall-cluster-only
branch
from
a3a0ccd to
e18ec61
Compare
|
/ci |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 40.66% 40.49% -0.18%
==========================================
Files 41 41
Lines 6730 6786 +56
==========================================
+ Hits 2737 2748 +11
- Misses 3879 3922 +43
- Partials 114 116 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noam Gal <noam.gal@octopus.com>
ATGardner
commented
Feb 3, 2025
|
|
||
| var revision string | ||
| if r != nil && repofs != nil { |
ATGardner
commented
Feb 3, 2025
| RunE: func(cmd *cobra.Command, _ []string) error { | ||
| kubeContextName, err := cmd.Flags().GetString("context") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get kube context name: %w", err) | ||
| } | ||
|
|
||
| if !clusterOnly { | ||
| if cloneOpts.Repo == "" || cloneOpts.Auth.Password == "" { |
There was a problem hiding this comment.
check if cobra can handle this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new flag
--clusterOnlyto the uninstall command, allowingdirect uninstallation from the cluster without interacting with the git
repository.
Signed-off-by: Noam Gal noam.gal@octopus.com