-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argocd-autopilot repo uninstall removes autopilot repo #630
Comments
@darnone We should probably make it require a flag to remove manifests so it doesn't happen accidentally. It is documented but I could see that being a surprise and it is destructive so better safe than sorry. |
@darnone I think this is a feature we can get done. Another note is that it doesn't destroy the repo, as you can just revert the commit to get everything back. But I also agree that's inconvenient and it makes more sense on uninstall to keep files unless specifically requested. |
i made some tests in the code, and i can easily support that. how do you suggest we go about it?
but just doing the 3rd step would also work and leave the cluster clean. should i change the default behavior and have an optional flag to do it "gitops"? or should i leave the default, and have the optional flag to run uninstall on cluster only? |
i have added a flag of what do you think @todaywasawesome @darnone - would that handle the issue? |
When argocd-autopilot repo uninstall is executed, it delete the apps, bootstrap, projects directories. There should be an option to not delete the repo on uninstall which destroyed my repo. That was quite unexpected.
Latest version for argocd-autipilot
The text was updated successfully, but these errors were encountered: