-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Update vueselect dependency to v3 #674
[3.x] Update vueselect dependency to v3 #674
Conversation
That would close #626 I think, that would be really nice ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mazeeblanke! I tested this and it looked like we are losing our CSS customization on select fields powered by vue-select.
@ifox thank you for the feedback. I will go through it again and fix it |
I think that since we are on this we can also add support for the We could take a similar array as the |
Moving this onto 3.x |
Codecov Report
@@ Coverage Diff @@
## 3.x #674 +/- ##
=========================================
Coverage 58.59% 58.59%
Complexity 2779 2779
=========================================
Files 176 176
Lines 8432 8432
=========================================
Hits 4941 4941
Misses 3491 3491 Continue to review full report at Codecov.
|
Update vue select to version 3.