Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Update vueselect dependency to v3 #674

Merged

Conversation

mazeeblanke
Copy link
Contributor

Update vue select to version 3.

  1. Replaced the onSearch prop with the search event has using the same parameters in it's place.
  2. import the css file for the vue-select

@tchapi
Copy link
Contributor

tchapi commented Jul 16, 2020

That would close #626 I think, that would be really nice !

Copy link
Member

@ifox ifox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mazeeblanke! I tested this and it looked like we are losing our CSS customization on select fields powered by vue-select.

@mazeeblanke
Copy link
Contributor Author

@ifox thank you for the feedback. I will go through it again and fix it

@haringsrob
Copy link
Contributor

I think that since we are on this we can also add support for the selectable https://vue-select.org/guide/selectable.html#selectable-prop option.

We could take a similar array as the options.

@haringsrob haringsrob changed the base branch from 2.x to 3.x April 5, 2022 06:36
@haringsrob haringsrob changed the title Update vueselect dependency to v3 [3.x] Update vueselect dependency to v3 Apr 5, 2022
@haringsrob
Copy link
Contributor

Moving this onto 3.x

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #674 (02c1660) into 3.x (8c3dc56) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                3.x     #674   +/-   ##
=========================================
  Coverage     58.59%   58.59%           
  Complexity     2779     2779           
=========================================
  Files           176      176           
  Lines          8432     8432           
=========================================
  Hits           4941     4941           
  Misses         3491     3491           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3dc56...02c1660. Read the comment docs.

@haringsrob haringsrob merged commit 4b9fdaf into area17:3.x Apr 5, 2022
@haringsrob haringsrob added this to the 3.x initial release milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants