Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] #1957: Fix keepalive. #2043

Merged
merged 2 commits into from
Jan 10, 2023
Merged

[3.x] #1957: Fix keepalive. #2043

merged 2 commits into from
Jan 10, 2023

Conversation

haringsrob
Copy link
Contributor

fixes #1957 on 3.x (to be ported)

@what-the-diff
Copy link

what-the-diff bot commented Jan 6, 2023

  • Add destroyValue method to BrowserField, ConnectorField and LocaleField
  • Call the new destroyValue methods in some components (Mediafield, Slideshow) when a field is destroyed or deleted
  • Remove form fields from store if they are removed from DOM tree

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 11.62% // Head: 11.62% // No change to project coverage 👍

Coverage data is based on head (634d2fa) compared to base (fecd20e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x    #2043   +/-   ##
=========================================
  Coverage     11.62%   11.62%           
  Complexity     3858     3858           
=========================================
  Files           302      302           
  Lines         14946    14946           
=========================================
  Hits           1738     1738           
  Misses        13208    13208           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@haringsrob haringsrob merged commit 1844786 into 3.x Jan 10, 2023
@haringsrob haringsrob deleted the fix-keepalive branch January 10, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant