Don't forbid unknown files in a library #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code forbids any files it does not know about, but this is bad because: - It breaks forward compatibility if we later add more files or directories to the library format. - It breaks for people who want to have some extra stuff in their library (say, .gitignore or a README file). We can't keep a list of "allowed" stuff, since there will always be stuff missing. This commit removes that code and just allows all files again.
|
+1 |
cmaglie
added a commit
that referenced
this pull request
Nov 20, 2013
mfalkvidd
added a commit
to mfalkvidd/arduino-builder
that referenced
this pull request
Dec 18, 2016
Warning about unknown folders was considered bad in arduino/Arduino#1692 but the problem is still present in arduino-builder. This has caused issues like arduino#70 (comment) which resulted in arduino#162 The original arguments in Arduino/pull/1692 still apply: * It breaks forward compatibility if we later add more files or directories to the library format. * It breaks for people who want to have some extra stuff in their library (say, .gitignore or a README file). We can't keep a list of "allowed" stuff, since there will always be stuff missing.
mfalkvidd
added a commit
to mfalkvidd/arduino-builder
that referenced
this pull request
Dec 18, 2016
Warning about unknown folders was considered bad in arduino/Arduino#1692 but the problem is still present in arduino-builder. This has caused issues like arduino#70 (comment) which resulted in arduino#162 The original arguments in Arduino/pull/1692 still apply: * It breaks forward compatibility if we later add more files or directories to the library format. * It breaks for people who want to have some extra stuff in their library (say, .gitignore or a README file). We can't keep a list of "allowed" stuff, since there will always be stuff missing. Signed-off-by: Mikael Falkvidd git@mjo.se <git@mjo.se>
mfalkvidd
added a commit
to mfalkvidd/arduino-builder
that referenced
this pull request
Dec 18, 2016
Warning about unknown folders was considered bad in arduino/Arduino#1692 but the problem is still present in arduino-builder. This has caused issues like arduino#70 (comment) which resulted in arduino#162 The original arguments in Arduino/pull/1692 still apply: * It breaks forward compatibility if we later add more files or directories to the library format. * It breaks for people who want to have some extra stuff in their library (say, .gitignore or a README file). We can't keep a list of "allowed" stuff, since there will always be stuff missing. Signed-off-by: Mikael Falkvidd git@mjo.se <git@mjo.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code forbids any files it does not know about, but this is
bad because:
directories to the library format.
library (say, .gitignore or a README file). We can't keep a list of
"allowed" stuff, since there will always be stuff missing.
This commit removes that code and just allows all files again.