Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkggrep: script for grepping for an exact symbol #84

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

christian-heusel
Copy link
Member

sogrep covers most use-cases but sometimes one wants to look for a
specific symbol. This script was originally written by foutrelis.

Signed-off-by: Christian Heusel christian@heusel.eu

@Antiz96
Copy link
Member

Antiz96 commented Jan 6, 2025

Thanks ☺️

Despite being a very simple script, I guess we still want a SPDX Licence header and some form of documentation (e.g. a "help" function or a top comment).

@christian-heusel christian-heusel self-assigned this Jan 6, 2025
@christian-heusel christian-heusel marked this pull request as draft January 6, 2025 10:30
@christian-heusel christian-heusel changed the title Add sogrep-zst: script for grepping for an exact symbol Add package-grep: script for grepping for an exact symbol Jan 6, 2025
@christian-heusel christian-heusel marked this pull request as ready for review January 6, 2025 12:44
@Foxboron
Copy link
Member

Foxboron commented Jan 6, 2025

We now have pkgsearch and package-grep. Is the naming confusing or is it fine?

@christian-heusel
Copy link
Member Author

We now have pkgsearch and package-grep. Is the naming confusing or is it fine?

Naming things is hard, I'm open for alternative suggestions!

@Foxboron
Copy link
Member

Foxboron commented Jan 6, 2025

Naming things is hard, I'm open for alternative suggestions!

I don't have a good alternative. I just thought I'd mention it before we merged it in case someone can come up with anything :p Else we can just merge this

@Antiz96
Copy link
Member

Antiz96 commented Jan 6, 2025

We now have pkgsearch and package-grep. Is the naming confusing or is it fine?

Naming things is hard, I'm open for alternative suggestions!

Since we have 'sogrep' for sonames, we could have 'symgrep' for symbols? 🐱

@christian-heusel
Copy link
Member Author

christian-heusel commented Jan 6, 2025

Since we have 'sogrep' for sonames, we could have 'symgrep' for symbols? 🐱

I thought about this aswell, the issue is just that compared to 'sogrep' this utility is not really only usuable to grep for symbol names 🤔

@Antiz96
Copy link
Member

Antiz96 commented Jan 6, 2025

What about grepkg or grepackage?

@Antiz96
Copy link
Member

Antiz96 commented Jan 6, 2025

What about grepkg or grepackage?

This is just a wild proposition for a more "fun-ish" and less confusing name (compared to pkgsearch), but otherwise package-grep is fine I guess ^^

@Antiz96
Copy link
Member

Antiz96 commented Jan 7, 2025

Actually, to get along with sogrep, it could be the other way around. Like pkgrep (or pkggrep if the word game with the g from pkg and grep is confusing).

@Foxboron
Copy link
Member

Foxboron commented Jan 7, 2025

The intention was not to hold up the merging of this for a new name :) I don't mind pkgsls or pkggrep or some variations.

@Antiz96
Copy link
Member

Antiz96 commented Jan 7, 2025

The intention was not to hold up the merging of this for a new name :) I don't mind pkgsls or pkggrep or some variations.

pkggrep or pkgsgrep sound good to me (whatever feels the most natural), but no strong feeling about this. I leave the choice to @christian-heusel to go with whatever he prefers :)

sogrep covers most use-cases but sometimes one wants to look for a
specific symbol.

The base version for this script was originally written by foutrelis.

Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel changed the title Add package-grep: script for grepping for an exact symbol Add pkggrep: script for grepping for an exact symbol Jan 9, 2025
@christian-heusel
Copy link
Member Author

I have now gone with pkggrep 😊 Please re-review!

Copy link
Member

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Antiz96 Antiz96 merged commit bfc86bf into master Jan 9, 2025
1 check passed
@Antiz96 Antiz96 deleted the add-sogrep-zst branch January 9, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants