Clean docstrings of algo fit #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @caglayantuna !
LGTM, just a couple minor suggestions.
| @@ -198,64 +202,15 @@ def _initialize_algo(self, model: AbstractModel, dataset: Dataset) -> State: | |||
|
|
|||
| return state | |||
|
|
|||
| def _terminate_algo( | |||
There was a problem hiding this comment.
I thought we deleted this already, didn't we ?
There was a problem hiding this comment.
I opened a second PR and closed previous one when I am working on it. It seems that I forgot to delete it in the second PR. So, it is time remove it because it is useless
There was a problem hiding this comment.
OK, thanks for the explanation.
apply suggestions Co-authored-by: Gensollen <nicolas.gensollen@gmail.com>
NicolasGensollen
approved these changes
Mar 5, 2025
| @@ -198,64 +202,15 @@ def _initialize_algo(self, model: AbstractModel, dataset: Dataset) -> State: | |||
|
|
|||
| return state | |||
|
|
|||
| def _terminate_algo( | |||
There was a problem hiding this comment.
OK, thanks for the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates docstrings of
algo/fitfiles as it is mentioned in issue #122. I checked the doc locally and it seems ok to me. Also, I corrected minor things indag.pyfile related to docstrings.