Handle auto value through the rowHeight prop on the CardLayout component #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpierre
reviewed
Jan 7, 2020
- Validate strings only for 'auto', or set a failed prop warning otherwise. Co-Authored-By: Pierre Bertet <hello@pierre.world>
Evalir
force-pushed
the
card-auto-height
branch
from
61abc60 to
bc94e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"auto"on therowHeightprop, handling the CSS properly instead of setting auto values in a hacky way for the card.Closes #635 , discussion here.