Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve RootPortal page bug #673

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Nov 22, 2019

  • Changed size prop from "compact" (deprecated) to "small". This was making the page not render due to an uncaught error.

This PR closes #674

@auto-assign auto-assign bot requested a review from bpierre November 22, 2019 01:19
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was making the page not render due to an uncaught error.

Oof, that should be caught in the deprecation checks in Button.

Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sohkai it was a bug in this page, size="compact" was never supported on Button (compact=true was). What’s new is the prop type error 😄

@bpierre bpierre merged commit e063be6 into aragon:master Nov 22, 2019
@Evalir Evalir deleted the rootportal-page-fix branch November 22, 2019 11:52
@Evalir
Copy link
Contributor Author

Evalir commented Nov 22, 2019

@bpierre Yeah; it seems to come from the sizeStyles function relying on being passed a valid prop to then get the appropriate styles from the SIZE_STYLES array. 😃 Maybe a solution would be to introduce a check on the props on the sizeStyles function or the Button component itself to see if they're valid and if not, set them to a default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery bug: Root portal page doesn't load
3 participants