New style permissions #899
Conversation
…dant information from usePerssionsByRole()
| @@ -2,7 +2,7 @@ import React from 'react' | |||
| import PropTypes from 'prop-types' | |||
| import { CardLayout } from '@aragon/ui' | |||
| import { AppType } from '../../../prop-types' | |||
| import AppCard from '../AppCard' | |||
| import AppCard from '../../../components/AppCard/AppCard' | |||
There was a problem hiding this comment.
Hmm, I think the intention was to move AppCard into src/apps/Permissions/Home/; do you think we'll use this component elsewhere?
There was a problem hiding this comment.
I was thinking about App Center yes, but they might be different enough to not share the same component:
| onPathRequest( | ||
| location.screen === 'app' | ||
| ? `/app/${proxyAddress}/role/${roleBytes}` | ||
| : `/role/${proxyAddress}${roleBytes}` |
There was a problem hiding this comment.
What do you think about using a . to separate the two, to make it a bit nicer?
There was a problem hiding this comment.
Yes let’s do that 👍 Once the routing system has been a bit reshaped, I think we should make it part of the search (?=manageRole=…), since it doesn’t belong to /app/… anymore (and we could shorten the address / roleBytes).
|
@bpierre The new routing doesn't play nicely with global preference's routing :(. Going to an app detail in permissions, navigating to preferences, and trying to return to permissions results in a broken path. I think it's in one of the routing handlers for preferences; it removes a |
…tions * origin/newstyle: MenuPanel tweaks (#933) Home redesign (#934) SignerPanel: consolidate external transaction props into intent object (#931) useLocalIdentity: handle remove case (#930) Add AppInternal to manage the layout logic of internal apps (#932) MenuPanel: adjust for new styles (#923) SignerPanel: display warning for external transactions (#850) Remove Badge and update occurrences for Tag (#901) SignerPanel: adjust for new styles (#920) Organization Settings: replace old Settings app (#896) Permissions: new style (#899) Sidepanel: redesign feedback indicator (#907) eslint: make sure curly braces are used everywhere (#924) Org switcher: new style + add FavoritesMenu (#925)
|
Added all the contextual menus options and reviewed the side panels to match table labels.
|
|
A few comments after reviewing Permissions on preview:
Everything else is great!! 🎉🎉🎉 |
proxyAddresstoappAddress