Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messages configure step #752

Closed
wants to merge 2 commits into from
Closed

Conversation

wess
Copy link
Contributor

@wess wess commented Jan 30, 2024

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

wess added 2 commits January 30, 2024 13:30
Adds isPopoverDefined property to inputText to disable if popover is undefined
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 6:39pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 6:39pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 6:39pm

Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tihnk it should be false by default right?

Since not always the popover slot is used.

@TorstenDittmann TorstenDittmann deleted the fix-messages-configure-step branch February 8, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants