Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch getRect call for chromedriver in JSONWP mode #240

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Patch getRect call for chromedriver in JSONWP mode #240

merged 1 commit into from
Nov 6, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

Partially addresses appium/appium#11619

KazuCocoa
KazuCocoa approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@mykola-mokhnach mykola-mokhnach merged commit 8768298 into appium:master Nov 6, 2018
jlipps
jlipps reviewed Nov 6, 2018
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is OK but i wonder if this should happen inside jwproxy instead so anywhere we use jwproxy, protocol translation is handled appropriately? it could then also reuse code from basedriver to define the translation?

@mykola-mokhnach mykola-mokhnach deleted the size branch November 7, 2018 10:25
@KazuCocoa KazuCocoa mentioned this pull request Jan 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps left review comments

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@imurchie imurchie Awaiting requested review from imurchie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @jlipps @KazuCocoa