Test source document #343
Merged
Test source document #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dpgraham
commented
Dec 11, 2018
dpgraham
commented
- Add a test that would cause a Java heap error, if not for the XML traversal depth limit introduced by: Limit traversal depth and maximum length of xml values to avoid unexpected OOM errors #341
- Runs the tests on Travis CI now. Skips the Espresso Server test by adding a property that tells the test to be skipped.
|
Looks good, but hold on with tests please, until the original problem is fully addressed. |
|
@mykola-mokhnach How about we commit the tests now, and then afterwards I'll update the tests to reflect any new changes. |
|
I would prefer to wait. But if you are in rush... |
|
@mykola-mokhnach Sure... do you have any recommendations for other cases that we can test on SourceDocument? I'd like to get pretty good coverage. |
dpgraham
force-pushed
the
dpgraham-unit-tests
branch
from
0730124 to
59fda00
Compare
| @@ -317,4 +317,8 @@ public String toXMLString() throws AppiumException { | |||
| throw new XPathLookupException(xpathSelector, xe.getMessage()); | |||
| } | |||
| } | |||
|
|
|||
| public static void $setMaxTraverseDepth(int maxTraverseDepth) { | |||
There was a problem hiding this comment.
I'd rather mark it as visibleForTesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.