This repository was archived by the owner on Aug 14, 2020. It is now read-only.
ace: Fix manifest arch error #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manifest contains values for the ACI arch and OS, not the go language values. To avoid confusion, change the symbols 'GOOS" and 'GOARCH' to 'ACI_OS' and 'ACI_ARCH', and provide conversion as needed. Fixes errors like these when run an ARM64 machines: bad arch "arm64" for linux (must be one of: [amd64 i386 aarch64 aarch64_be armv6l armv7l armv7b ppc64 ppc64le s390x]) Signed-off-by: Geoff Levand <geoff@infradead.org>
|
/cc @squeed |
|
LGTM too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest contains values for the ACI arch and OS, not the go
language values. To avoid confusion, change the symbols 'GOOS" and
'GOARCH' to 'ACI_OS' and 'ACI_ARCH', and provide conversion as
needed.
Fixes errors like these when run an ARM64 machines:
bad arch "arm64" for linux (must be one of: [amd64 i386 aarch64 aarch64_be armv6l armv7l armv7b ppc64 ppc64le s390x])