This repository was archived by the owner on Aug 14, 2020. It is now read-only.
spec: add os/linux/selinux-context isolator #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonboulle @squeed PTAL. |
jonboulle
reviewed
Nov 15, 2016
| * **level** case-sensitive string containing the level portion of the SELinux security context to be used to label the current pod or application. | ||
|
|
||
| **Notes:** | ||
| 1. Only a single `os/linux/selinux-context` isolator can be specified per-pod. |
There was a problem hiding this comment.
If a context is applied to a pod, does this just mean it's for all apps (unless they have overrides), or also for any executor processes involved in running the pod? (i.e. stage1 for rkt)
There was a problem hiding this comment.
It also applies to other processes in the pod context. Thanks for highlighting this, I'll make it explicit in the spec.
|
LGTM modulo clarification on pod thing |
This commit introduces an "os/linux/selinux-context" isolator, which can be applied at both app and pod scope.
lucab
force-pushed
the
to-upstream/selinux-context
branch
from
3724998 to
34360b3
Compare
|
Amended with the clarification regarding pod-context. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an "os/linux/selinux-context" isolator, which
can be applied at both app and pod scope.