-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
I don't want to spread all the props; I want this to be a container with well-defined options. I also want to find a better solution than needing to add |
@justinanastos sounds good, I switched to just the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This failed CI because you didn't add a semver label. Please read the README (https://github.com/apollographql/space-kit#releases) to see why this matters.
Also explained in the readme in that same section, the title of this PR is what's going to show in the changelog. If the title isn't enough to explain, then add a ## release notes
section, again, per the readme.
🚀 PR was released in v1.5.0 🚀 |
I just realized this PR adds the |
@justinanastos unfortunately they still got passed through in |
Make label optional again
Im not sure why this went away, adding it back since it seemed like an unintentional change to make it required.
Proptypes extends
InputHTMLAttributes
Im not sure when this went away either, but without it you have to spread props to avoid type errors which isn't very ergonomic, for example
instead of