This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Modal: no title, no description dont render extra margin-top #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cy: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
cy
added
minor
cy
force-pushed
the
cy/modal-optional-margin-top
branch
from
ff881ed to
664ee76
Compare
cy
commented
Aug 23, 2021
| @@ -82,7 +82,7 @@ interface Props { | |||
| /** | |||
| * Title of the modal | |||
| */ | |||
| title: React.ReactNode; | |||
| title?: React.ReactNode; | |||
There was a problem hiding this comment.
this could have been passed as null before, and there is a null check on https://github.com/apollographql/space-kit/pull/373/files#diff-1be7e63e7570ebe66e4559909557f52a74c7eaef41906bb9e6078e0d376201c3R263
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/mdg-private/studio-ui/pull/4669, a modal with no title and no description does not need the
margin-topadded to space the content from the title and description.Before
After
📦 Published PR as canary version:
9.6.1-canary.373.9851.0✨ Test out this PR locally via:
npm install @apollo/space-kit@9.6.1-canary.373.9851.0 # or yarn add @apollo/space-kit@9.6.1-canary.373.9851.0