This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Update themed components to respect theme from SpaceKitProvider
#352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might consider making this a major, it cooould cause some weird behaviour if someone was using the theme provider (no worries if I missed the merge :P ) |
daniman
added
major
Jephuff
reviewed
Jun 2, 2021
Jephuff
reviewed
Jun 2, 2021
Jephuff
approved these changes
Jun 2, 2021
Co-authored-by: Jeffrey Burt <hi@jeffreyburt.com>
Co-authored-by: Jeffrey Burt <hi@jeffreyburt.com>
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all our components which already have theme awareness built in to look for their theme from
SpaceKitProviderin addition to accepting athemeprop. This should be a no-op to all current users (we continue to default to the "light" theme), but should allow users interested in dark components to use theSpaceKitProviderto theme all components at once.Please hide whitespace changes to review.
📦 Published PR as canary version:
10.0.0-canary.352.9481.0✨ Test out this PR locally via:
npm install @apollo/space-kit@10.0.0-canary.352.9481.0 # or yarn add @apollo/space-kit@10.0.0-canary.352.9481.0