This repository was archived by the owner on Jan 20, 2022. It is now read-only.
AR-2016 Allow Tooltip to wrap a Button that is disabled
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/AR-2016/tooltip-on-disabled-button
branch
from
7b9cf6e to
81f5e35
Compare
Jephuff
reviewed
Jan 25, 2021
| "onClick", | ||
| // If we're overriding the default disabled behavior, then strip | ||
| // it out from the props we'll pass to the element. | ||
| overrideDisabledBehavior ? "disabled" : "", |
There was a problem hiding this comment.
Is there an aria prop we should/could pass to make sure the button is still semantically disabled?
There was a problem hiding this comment.
Only kind-of. We can use aria-disabled, but this will only provide special behavior for screen readers. I'll add it.
There was a problem hiding this comment.
ooh nice, thats probably where it matters most so thats perfect :)
justinanastos
force-pushed
the
justin/AR-2016/tooltip-on-disabled-button
branch
2 times, most recently
from
8413d9e to
0973670
Compare
… Tooltip We'll need this so components can have special behavior if they live inside of a Tooltip
justinanastos
force-pushed
the
justin/AR-2016/tooltip-on-disabled-button
branch
from
0973670 to
cafa14b
Compare
Jephuff
approved these changes
Jan 27, 2021
| "onClick", | ||
| // If we're overriding the default disabled behavior, then strip | ||
| // it out from the props we'll pass to the element. | ||
| overrideDisabledBehavior ? "disabled" : "", |
There was a problem hiding this comment.
ooh nice, thats probably where it matters most so thats perfect :)
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by capturing pointer events to signal that the cursor is over the button and then applying
disabledstyles directly to thebuttonelement and removing thedisabledproperty so that tippy.js will show the tooltip. I went with this approach because then we can still test fordisabledbuttons.AR-2016
Testing to see how this looks in Studio UI https://github.com/mdg-private/studio-ui/pull/3700
📦 Published PR as canary version:
8.12.1-canary.298.7907.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.12.1-canary.298.7907.0 # or yarn add @apollo/space-kit@8.12.1-canary.298.7907.0