This repository was archived by the owner on Jan 20, 2022. It is now read-only.
fix(Popover): Fix resizing of Popover
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/popover-autosize-refactor
branch
from
598473e to
2a63ec0
Compare
timbotnik
approved these changes
Nov 24, 2020
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popovers had a known issue where resizing the viewport when a popover is already using a max-width would cause the popover to not fill the viewport's height. This got brought up when we started using dynamic content inside of a popover, which is completely plausible. This fixes the resizing issue!
📦 Published PR as canary version:
8.3.1-canary.278.6618.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.3.1-canary.278.6618.0 # or yarn add @apollo/space-kit@8.3.1-canary.278.6618.0