This repository was archived by the owner on Jan 20, 2022. It is now read-only.
AP-1011 Stop wrapping long text in Buttons #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/AP-1011/no-wrap-buttons
branch
from
53084a4 to
7ca70b7
Compare
jgzuke
approved these changes
Oct 2, 2019
|
🚀 PR was released in v2.11.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue https://apollographql.atlassian.net/browse/AP-1011
Intent
Stop wrapping long text in Buttons. Instead force the button to grow. See the "long text" storybook story under "Button" to see what this means.
Review
Review this all at once, it's a small change.
Additional Notes
I'd much rather there was a way to create a story that didn't show in the mdx docs, but I haven't found a way to do that yet.